Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add about dialog and window for helping apps make a pretty about screen #87

Merged
merged 8 commits into from
Mar 26, 2024

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Mar 25, 2024

Matching the parallax look in develop version of fyne_demo.
Looks sweet :)

about

also added a new general “fyne-x” demo command for when we don’t really need a full app to show off a new component.

@coveralls
Copy link

coveralls commented Mar 25, 2024

Pull Request Test Coverage Report for Build 8433207695

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 47.817%

Totals Coverage Status
Change from base Build 7933141749: 0.0%
Covered Lines: 1884
Relevant Lines: 3940

💛 - Coveralls

@Jacalz
Copy link
Member

Jacalz commented Mar 25, 2024

Nice stuff. Kind of related to Jacalz/rymdport#143 which I opened recently.

Something about having the version above seems strange to me. Maybe we can consider something like the following screenshot (smaller text below the icon)?

dialog/about.go Show resolved Hide resolved
dialog/about.go Show resolved Hide resolved
dialog/about.go Outdated Show resolved Hide resolved
dialog/about.go Outdated Show resolved Hide resolved
@andydotxyz
Copy link
Member Author

That's all addressed now (and new images added to show)

@andydotxyz andydotxyz requested a review from Jacalz March 26, 2024 09:05
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is looking perfect now. I haven't been able to test it locally (due to being away from my laptop) but the code looks great.

@andydotxyz andydotxyz merged commit 3ba9170 into fyne-io:master Mar 26, 2024
7 checks passed
@andydotxyz andydotxyz deleted the feature/about branch March 26, 2024 13:10
@Jacalz Jacalz mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants